Restructure SchemaGenerator for easier subclassing #5271
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow adding new default list actions so that bulk actions can be included in the schema with minimal changes.
3 tasks
|
This is superseded by #5354. Advice now:
Interested in any sticking points there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Restructure
SchemaGeneratorto allow easier subclassing. In particular, to make adding new list actions (e.g. bulk update) easy.It's absolutely crucial for using interactive documentation in conjunction with DRF-bulk — doing otherwise requires maintaining about a hundred lines of pointless copy-paste. (In particular I need it for this)
The whole changeset is basically just moving
is_custom_actionandis_list_viewfunctions to the class so they can be overridden and use class attributes in conditions instead of hardcoded values. Shouldn't break anything unless those functions are used directly somewhere in the code (however I could provide compatibility just if required).